Merged
Conversation
redsun82
added
the
depends on internal PR
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the fmt library from version 10.0.0 to 12.1.0 and simplifies the formatters configuration by leveraging the standard library formatters now available in fmt/std.h without requiring RTTI.
Key changes:
- Updated fmt dependency from 10.0.0 to 12.1.0
- Replaced custom formatters for
std::filesystem::pathandstd::error_codewith the standardfmt/std.hheader - Added
FMT_USE_RTTI 0macro definition to disable RTTI requirements for fmt's standard library support
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| MODULE.bazel | Updates the fmt dependency version from 10.0.0 to 12.1.0 |
| swift/logging/Formatters.h | Removes custom formatter implementations and switches to fmt/std.h with RTTI disabled |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
redsun82
force-pushed
the
redsun82/update-fmt
branch
from
9a5b2ee to
03aab97
Compare
jketema
previously approved these changes
Nov 19, 2025
redsun82
force-pushed
the
redsun82/update-fmt
branch
from
03aab97 to
6b17edb
Compare
jketema
previously approved these changes
Nov 19, 2025
redsun82
removed
the
depends on internal PR
redsun82
force-pushed
the
redsun82/update-fmt
branch
from
6b17edb to
31cf166
Compare
redsun82
force-pushed
the
redsun82/update-fmt
branch
from
31cf166 to
83b3711
Compare
esbena
approved these changes
Nov 27, 2025
Contributor
esbena
left a comment
esbena
left a comment
There was a problem hiding this comment.
This seems plausible.
I'm impressed with bazel's flexibility wrt. workarounds here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new version needs
FMT_UNICODEto be disabled on windows for us though. I've done that in a registry override.The change to
fix.pythere is to support theoverlaydirectory in the module registry, which I think is something new (and is used by thefmtmodule entry).